Project

General

Profile

Defect #1308

svn diff can't convert nil into String error on redmine_code_review-0.6.3 with redmine-2.4.2

Added by Sea Kang over 5 years ago.

Status:
新規(New)
Priority:
通常(Normal)
Assignee:
-
Category:
-
Target version:
-
Start date:
02/14/2014
Due date:
% Done:

0%

Estimated time:

Description

具体的な再現方法
What steps will reproduce the problem?
1. add a svn repository
2. enable code review
3. click repository, then click view difference.

期待する結果と実際の結果
What is the expected output? What do you see instead?

code review button was not showed.

下記コマンドの実行結果を教えてください。
Please give us a result of following command.

% ruby script/about

Please provide any additional information below.

Read fragment views/repositories/diff/11/48ee4d3c11dbf713affd8407faf546de 0.3ms
Read fragment views/repositories/diff/11/48ee4d3c11dbf713affd8407faf546de 0.1ms
Rendered repositories/diff.html.erb within layouts/base (2.3ms)
Rendered plugins/redmine_code_review/app/views/code_review/_html_header.html.erb (1.9ms)
Rendered plugins/redmine_code_review/app/views/code_review/_body_bottom.html.erb (1.5ms)
Completed 200 OK in 33.6ms (Views: 21.5ms | ActiveRecord: 2.5ms)
Started POST "/projects/mobileapp/code_review/update_diff_view" for 192.168.1.62 at 2014-02-14 16:52:15 +0800
Processing by CodeReviewController#update_diff_view as HTML
Parameters: {"rev"=>"1724", "path"=>"", "review_id"=>"", "action_type"=>"diff", "rev_to"=>"1723", "id"=>"mobileapp"}
Current user: test (id=1)
Completed 500 Internal Server Error in 11.8ms

TypeError (can't convert nil into String):
plugins/redmine_code_review/app/controllers/code_review_controller.rb:200:in `+'
plugins/redmine_code_review/app/controllers/code_review_controller.rb:200:in `update_diff_view'
actionpack (3.2.16) lib/action_controller/metal/implicit_render.rb:4:in `send_action'
actionpack (3.2.16) lib/abstract_controller/base.rb:167:in `process_action'
actionpack (3.2.16) lib/action_controller/metal/rendering.rb:10:in `process_action'
actionpack (3.2.16) lib/abstract_controller/callbacks.rb:18:in `block in process_action'
activesupport (3.2.16) lib/active_support/callbacks.rb:524:in `_run__1979336730169381357__process_action__1860297024977055165__callbacks'
activesupport (3.2.16) lib/active_support/callbacks.rb:405:in `__run_callback'
activesupport (3.2.16) lib/active_support/callbacks.rb:385:in `_run_process_action_callbacks'
activesupport (3.2.16) lib/active_support/callbacks.rb:81:in `run_callbacks'
actionpack (3.2.16) lib/abstract_controller/callbacks.rb:17:in `process_action'

git repository is ok.

Also available in: Atom PDF