Project

General

Profile

Defect #1336

Internal error when a user is deleted in Redmine

Added by Olivier Houdas almost 5 years ago. Updated almost 5 years ago.

Status:
終了(Closed)
Priority:
通常(Normal)
Target version:
Start date:
06/27/2014
Due date:
% Done:

100%

Estimated time:

Description

Steps :
  1. Activate Worktime on a project
  2. Make sure user "X" is listed in the list of members, displayed in the worktime tab
  3. Delete that user in Redmine admin (not simply locked, but deleted)
  4. Display the Work time tab again on the project
    Result : Internal error
    Started GET "/redmine/work_time/show/geoconcept" for 192.168.9.13 at 2014-06-26 15:48:47 +0200
    Processing by WorkTimeController#show as HTML
      Parameters: {"id"=>"geoconcept"}
      Current user: admin (id=1)
    Completed 500 Internal Server Error in 2136.2ms
    
    NoMethodError (undefined method `active?' for nil:NilClass):
      plugins/redmine_work_time/app/controllers/work_time_controller.rb:638:in `block in member_add_del_check'
    
    

Fix suggestion:
Add a test on the user object in the loop (see patch attached)
This is not perfect (deleted users remain in the wt_members_order table), but at least it avoids the internal error.


Files

Associated revisions

Revision 325:e0ca1cf18c0b (diff)
Added by Tomohisa Kusukawa almost 5 years ago

fixes #1336 Internal error when a user is deleted in Redmine

Revision ad2f488c (diff)
Added by Tomohisa Kusukawa almost 5 years ago

fixes #1336 Internal error when a user is deleted in Redmine

History

#1

Updated by Tomohisa Kusukawa almost 5 years ago

  • Status changed from 新規(New) to 担当(Assigned)
  • Assignee set to Tomohisa Kusukawa
  • Target version set to 0.2.15

Thank you very much for this bug report.

#2

Updated by Tomohisa Kusukawa almost 5 years ago

  • Status changed from 担当(Assigned) to 解決(Resolved)
  • % Done changed from 0 to 100

更新履歴 commit:e0ca1cf18c0b で適用されました。

#3

Updated by Tomohisa Kusukawa almost 5 years ago

  • Status changed from 解決(Resolved) to 終了(Closed)

I released Ver.0.2.15.
http://www.r-labs.org/news/180

Also available in: Atom PDF