Project

General

Profile

Defect #1345

'Add Ticket' button no longer works with Chrome 37+

Added by Jamie Press about 5 years ago. Updated about 5 years ago.

Status:
終了(Closed)
Priority:
通常(Normal)
Target version:
Start date:
09/06/2014
Due date:
% Done:

100%

Estimated time:

Description

Since Chrome 37, the popup window method no longer works. It does still work in IE 11.

The same issue seems to be described here and may provide clues:
http://www.bugdebugzone.com/2014/08/sitecore-modal-pop-ups-are-not-working.html

Love worktime, and hope to have it still work in Chrome!

Thanks.


Files

popup_bug.jpg (73.2 KB) popup_bug.jpg Jamie Press, 09/06/2014 05:38 AM
wt-1345.patch (7.49 KB) wt-1345.patch Olivier Houdas, 09/12/2014 09:36 PM

Associated revisions

Revision 350:9b04d80abbab (diff)
Added by Tomohisa Kusukawa about 5 years ago

refs #1345 Change to Ajax from a modal dialog (Add Tickets)

Revision dc5e1838 (diff)
Added by Tomohisa Kusukawa about 5 years ago

refs #1345 Change to Ajax from a modal dialog (Add Tickets)

Revision 351:f432ed187e5b (diff)
Added by Tomohisa Kusukawa about 5 years ago

refs #1345 Change to Ajax from a modal dialog (update done ratio)

Revision 2054f3ef (diff)
Added by Tomohisa Kusukawa about 5 years ago

refs #1345 Change to Ajax from a modal dialog (update done ratio)

Revision 352:ebafbdda1955 (diff)
Added by Tomohisa Kusukawa about 5 years ago

fixes #1345 Change to Ajax from a modal dialog (relay ticket, etc)

Revision 844c527b (diff)
Added by Tomohisa Kusukawa about 5 years ago

fixes #1345 Change to Ajax from a modal dialog (relay ticket, etc)

Revision 356:8a1ae343b345 (diff)
Added by Tomohisa Kusukawa about 5 years ago

refs #1345 done ratio should be clickable only at permitted

Revision d7493c99 (diff)
Added by Tomohisa Kusukawa about 5 years ago

refs #1345 done ratio should be clickable only at permitted

Revision 0432762f
Added by Tomohisa Kusukawa about 5 years ago

fixes #1345 Close branch

History

#1

Updated by Tomohisa Kusukawa about 5 years ago

  • Status changed from 新規(New) to 担当(Assigned)
  • Assignee set to Tomohisa Kusukawa

Thank you for your report.
I will consider how to respond.

#2

Updated by Jamie Press about 5 years ago

Just some updates, as we searched for a workaround.

  1. Firefox 32 (latest) works properly.
  2. IE 11 works sometimes (occasionally opens a blank popup window)

Please note that our test case is ONLY the 'add ticket' button in Worktime.

Thanks.

#3

Updated by Olivier Houdas about 5 years ago

The issue is due to Chrome 37 stopping to include showModalDialog() in its javascript engine.
You will find a patch attached with a way to fix the issue. It is not very elegant, as I had to work around the fact that the replacement function is not modal (asynchronous call) and therefore we need to split the functions in 2 : one part before the popup, and a second part executed after.

#4

Updated by Tomohisa Kusukawa about 5 years ago

  • Status changed from 担当(Assigned) to 解決(Resolved)
  • % Done changed from 0 to 100

更新履歴 commit:ebafbdda1955 で適用されました。

#5

Updated by Tomohisa Kusukawa about 5 years ago

Thank you very much for your report and especially patches.

I was considered variety,
The Ajax was desirable for usability of the future, maybe.

If you are available, please try following alpha version.

mercurial clone
https://tkusukawa@bitbucket.org/tkusukawa/redmine_work_time

download
https://bitbucket.org/tkusukawa/redmine_work_time/downloads
-> Branches tab -> #1345

#6

Updated by Olivier Houdas about 5 years ago

It seems to work fine (tested only adding an issue and changing completion percentage). I tested on RM 2.5.2.
By the way, completion percentages are clickable even though Redmine's option is set to follow issues statuses (in that case, changing the value has no effect). It might make sense not to show a link if Issue.use_status_for_done_ratio? is true.

#7

Updated by Tomohisa Kusukawa about 5 years ago

Certainly.

I modified at commit:8a1ae34

Thanks again!

#8

Updated by Tomohisa Kusukawa about 5 years ago

更新履歴 commit:9ec9d92b7324 で適用されました。

#9

Updated by Tomohisa Kusukawa about 5 years ago

  • Status changed from 解決(Resolved) to 終了(Closed)
  • Target version set to 0.2.16

Close branch and merge to default line. (repository)
Thank you.

Also available in: Atom PDF